conn: check we can use compression in startup #1215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the user asks to use compression check that the remote server supports it by making an options call first. Rejig conn startup to be self contained.
alourie
reviewed
Oct 12, 2018
| m["COMPRESSION"] = compressor | ||
| break | ||
| } | ||
| } |
There was a problem hiding this comment.
if we're out of the for loop, but m["COMPRESSION"] is not set, then probably not supported by the backend. So, I reckon, reset s.conn.compressor here to nil, and print something appropriate in the log.
There was a problem hiding this comment.
actually, no, ignore. Not overly important to reset it, as probably the coordinator does startup only once.
alourie
approved these changes
Oct 12, 2018
| m["COMPRESSION"] = compressor | ||
| break | ||
| } | ||
| } |
There was a problem hiding this comment.
actually, no, ignore. Not overly important to reset it, as probably the coordinator does startup only once.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the user asks to use compression check that the remote server
supports it by making an options call first.
Rejig conn startup to be self contained.
fixes #1205